fix: modify to run with @pinojs/dateformat#614
fix: modify to run with @pinojs/dateformat#614Uzlopak wants to merge 4 commits intopinojs:dateformatfrom
Conversation
|
Basically SYS: is the same as GMT. I could just modify our dateformat to even avoid that |
jsumners
left a comment
jsumners
left a comment
There was a problem hiding this comment.
Are there any technical reasons @pinojs/dateformat is not a drop-in replacement for dateformat?
|
No, it was an accidental typo. |
Sorry. I don't follow. I expected the only changes necessary would be replacing every occurrence of |
|
No, there are no technical reasons. I made a mistake, by making a capital F instead of a lowercase f. I will fix it. I am just currently commuting... I provide you with a fix in fee hours |
|
@jsumners |
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm once our dateformat method hits 1.0.0
|
Changing this PR to draft. Will get back to it some day. |
|
I'm going through our modules in alphabetical order and getting the updated for |
|
yes, i will take care of it today. |
|
wdyt of this in combination with pinojs/dateformat#5 ` |
|
So.. modified this PR to use only the improved dateformat function and not the DateFormatter from pinojs/dateformat. It is not the implementation for high performance, as for that you should instantiate the dateformatter. But this change should be already faster than the original dateformat function. If we one day have interest in more performance, we then only need to use DateFormatter. |
3 participants
@jsumners
I am not maintainer here, so I could not push into your branch.